Improve handling of copilot_node_command - #552
Merged
Merged
Conversation
Collaborator
|
Very happy with this initiative, I agree tests will be quite beneficial seeing the back and forth on this issue too. |
timhugh
force-pushed
the
timheuett/nodejs-commands
branch
from
August 28, 2025 05:45
ba8438e to
b7365f3
Compare
timhugh
marked this pull request as ready for review
August 28, 2025 05:52
Contributor
Author
|
Okay, great! I did some test cleanup. I'm pretty new to mini.test and I suspect there might be a more idiomatic way to structure the tests (maybe using sets and stubbing in the pre/post hooks instead of the stub methods?), but at least this covers a lot of cases |
Collaborator
|
Looks good, but I have a ton of failing tests which I do not think were caused by this but something on the LSP-side. |
Collaborator
|
Ok the issue resolved itself, all green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little history:
copilot_node_commandconfig because of excessive validation. This was resolved in Relax validation for copilot_node_command #527vim.split. This was resolved in Fixes regression where node_command contained spaces #541Unfortunately, that fix undid the previous fix, so this PR aims to resolve both:
get_execute_commandandget_node_versionfunctions of the nodejs module to prevent regressioncopilot_node_commandcan now be configured two ways:copilot_node_command = "/path to/node"copilot_node_command = { "mise", "x", "node@lts", "--", "node" }